Add support for NO_COLOR environment variable #1207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the NO_COLOR environment variable is present (with any value), disable colour output. This can be overrident explicitly with the `--color` switch. See also: http://no-color.org/
|
There's unfortunately no test for this: the test environment has colour suppression due to the tty detection, and because of this all colour tests have the A test could be implemented by removing the |
|
I don't mean to annoy you by closing this. It's just that we seem to disagree on the usefulness of this feature. People can read my reasons here: https://news.ycombinator.com/item?id=17244313 Sorry. |
|
I surely would have liked that also this tool would have simply conformed to NO_COLOR, instead of needing to extra tricks for this case :() Thus it is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the NO_COLOR environment variable is present (with any value), disable
colour output. This can be overrident explicitly with the
--colorswitch.See also: http://no-color.org/